I would think that a job as a Street Photographer is basically extinct now with everyone carrying around their phone which most take much better photos than a lot of the cameras.
In 2009 a few of these street photographers used to hang around looking for people to take photos of.
They would get you to pose, take the photos and then zip off to get them developed and about 20 mins later he or she would appear with a nice set of photos.
During my time, I got some taken of me, especially around Hoan Kiem Lake when we had visitors.
If you see someone who offers you this service . . . .. . and you have a bit of time and a couple bucks in your pocket, get some done.